From: Georges Basile Stavracas Neto <georges.stavracas@gmail.com>
Date: Thu, 21 Nov 2019 21:21:44 +0000 (-0300)
Subject: baseAppView: Destroy icon when removing
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~781^2^2~397
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=bfc7c1cd65eee4872aeff837a77f7c6e33aae0ef;p=gnome-shell.git

baseAppView: Destroy icon when removing

We cannot rely on the garbage collector to do that in a timely
manner, so destroy it explicitly.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/841
---

diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index a49ebe09a..5b9d4d87f 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -186,10 +186,11 @@ var BaseAppView = GObject.registerClass({
         // Remove old app icons
         removedApps.forEach(icon => {
             let iconIndex = this._allItems.indexOf(icon);
+            let id = icon.id;
 
             this._allItems.splice(iconIndex, 1);
-            this._grid.removeItem(icon);
-            delete this._items[icon.id];
+            icon.destroy();
+            delete this._items[id];
         });
 
         // Add new app icons